WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools: libxl: translate xvd[a-d] to hd[a-d] for

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: libxl: translate xvd[a-d] to hd[a-d] for new qemu
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 1 Apr 2011 13:01:34 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 01 Apr 2011 05:03:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19860.51769.282438.625567@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <d0dd569bfcb0f5f8e2d9.1301571093@xxxxxxxxxxxxxxxxxxxxx> <19860.51769.282438.625567@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-03-31 at 19:38 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH] tools: libxl: translate xvd[a-d] to 
> hd[a-d] for new qemu"):
> > tools: libxl: translate xvd[a-d] to hd[a-d] for new qemu
> > 
> > xvde+ are ignored.
> 
> I don't think this is strictly speaking correct.  According to the
> spec doc/misc/vbd-interface.txt, we are supposed to support vdevs in a
> variety of formats.
> 
> What this code ought to be doing is using the parsing function and
> then reconstituting the vdev name for qemu's benefit.

makes sense, I'd forgotten about the parsing function.

I guess for everything other than the sdX syntax I should translate the
result of libxl__device_disk_dev_number into an -hd[a-d] for values < 4
and ignore anything greater, but for sdX syntax I want to pass it
through as is? And is the limit 4 or 16 in that case? (I'm not 100% sure
of the old qemu's behaviour...)

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel