Re: [Xen-devel] [PATCH] Protocol change of suspending through xenbus [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Frank Pan writes ("[Xen-devel] [PATCH] Protocol change of suspending through 
xenbus"):
> Xend/libxl uses polling on suspending PV/PV-on-HVM guests.
> They simply check whether the guest has been suspended again
> and again. Guest has no chance to report errors to Xend/libxl.

I don't think this protocol is necessarily correct.

However I'm not sure the current code in libxl is correct either.  It
assumes that any value other than "suspend" in control/shutdown is a
guest ack.

> The following patch is for libxl. It creates a key in the xenbus:
> control/shutdown-error. Guest can post any error string into this
> key, and also libxl can return this error to the user/administrator
> asap.

What character set is this string in ?  What if it contains hostile
data ?  etc.

I think it might be better to report the details of the error in the
guest kernel logfile.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel