 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failu
| To: | Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure |
| From: | Dan Carpenter <error27@xxxxxxxxx> |
| Date: | Sat, 19 Mar 2011 08:44:34 +0300 |
| Cc: | kernel-janitors@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |
| Delivery-date: | Thu, 24 Mar 2011 16:50:16 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=j9ofTGXiHwwvTjGddNhXwQJ6/DlxgerXTu8dEOG67DA=; b=EYvp+py5n49sxumb+/zMP359OtxcF1VKaDE9NW5G1ucqQqpwwskhXB7XwMWcPvbg74 nBf+GAP8four+m304nfzXtFZJNUYVWazuhQHq37yRqegW3r+2VYogQnr/Btyvwpg8nIC pJkOQ6tWp0Z6Y5vij/cW8BOIgZtwn4g9DD6Ck= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=arnW69spBJvreiMGv50Zzauu6Y5Jf0KebQfKkICthXJbIOIw4TeheN5EOqpoaj/Gqe QtkKj21bShEVDK0diZyUxUsYzSnCs0aaMgHPJwb4uDLGNrUoq12cKgZZ4TIjzmtQVhd2 qw0icz3ffAzm5taycSOSe5OcM8QDuBObX77g4= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
copy_to_user() returns the amount of data remaining to be copied. We
want to return a negative error code here. The upper layers just
call WARN_ON() if we return non-zero so this doesn't change the
behavior. But returning -EFAULT is still cleaner.
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 017ce60..b0f9e8f 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int
offset, int pages)
map->vma->vm_start + map->notify.addr;
err = copy_to_user(tmp, &err, 1);
if (err)
- return err;
+ return -EFAULT;
map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
} else if (pgno >= offset && pgno < offset + pages) {
uint8_t *tmp = kmap(map->pages[pgno]);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: 2.6.39 crashes BUG: unable to handle kernel NULL pointer dereference at 000000000000042 .. cmos_checkintr+0x4d/0x55 under Xen as PV guest., John Stultz |
|---|---|
| Next by Date: | [Xen-devel] [patch 2/2] xen-gntdev: unlock on error path in gntdev_mmap(), Dan Carpenter |
| Previous by Thread: | [Xen-devel] [PATCH] xen: fix p2m section mismatches, Randy Dunlap |
| Next by Thread: | Re: [Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure, Konrad Rzeszutek Wilk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
