WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down in

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 23 Mar 2011 15:50:00 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 23 Mar 2011 09:10:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19850.5216.648380.789890@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1300723178@xxxxxxxxxxxxxxxxxxxxx> <2276552067f8cad61231.1300723198@xxxxxxxxxxxxxxxxxxxxx> <19850.5216.648380.789890@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-03-23 at 15:40 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH 20 of 30] tools: ocaml: push CFLAGS usage down 
> into the specific bindings"):
> > -
> > -#ifndef xen_mb
> > -#define xen_mb()   mb()
> > -#endif
> 
> This may be unneeded (I haven't checked) but if so shouldn't it be
> mentioned in the commit message ?
> 
> > -#xs.cmxa: $(foreach obj,$(OBJS),$(obj).cmx)
> etc.
> 
> Also.

Sorry, they both should have been separate patches. I'll wait till
you've applied the bits you are going to apply and then resend the bits
you didn't.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>