[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage

On Wed, 2011-03-23 at 15:40 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH 20 of 30] tools: ocaml: push CFLAGS usage down 
> into the specific bindings"):
> > -
> > -#ifndef xen_mb
> > -#define xen_mb()   mb()
> > -#endif
> 
> This may be unneeded (I haven't checked) but if so shouldn't it be
> mentioned in the commit message ?
> 
> > -#xs.cmxa: $(foreach obj,$(OBJS),$(obj).cmx)
> etc.
> 
> Also.

Sorry, they both should have been separate patches. I'll wait till
you've applied the bits you are going to apply and then resend the bits
you didn't.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings, Ian Jackson [Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings, Ian Campbell <=

Previous by Date:

[Xen-devel] Re: [PATCH 30 of 30] tools: remove pattern matched linking rules, Ian Jackson

Next by Date:

[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line, Ian Campbell

Previous by Thread:

[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings, Ian Jackson

Next by Thread:

[Xen-devel] Re: [PATCH 24 of 30] tools: Remove $(CFLAGS) from links lines, Ian Jackson

Indexes:

[Date] [Thread] [Top] [All Lists]