WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Fri, 18 Mar 2011 17:11:51 +0000
Cc: Jinsong Liu <jinsong.liu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 18 Mar 2011 10:13:21 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=mi+LK68jwlNs0gRYfvLe/ykvYAZknivLXgY5vSfIKdI=; b=QbCTYpJmy0HlbizTMZK1DZOL0Lm1PKKuJ3K/O3Q3p4hrnQh8eMBDIIOo9iJn0oG9va /h8RnMDXG6jA3IDircF7XR5hIM91L5V573nr0Itqq4vqHeBEjPX85kyYXJYqumpUn02f RBOMrLW7yitAjqzC9U0wweI0ckny/qCrgNN1Y=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m6PZCbwoqPLu2Ug8xZE60lda69WecdsZksQFNGfc+I7VTrs3nAGTHdcXHohPcaSrgR apfB8//gd/TdmMmrGDE65Sn5IGrJQ7TKxd/c+xjkNgqJsmR/IEgy3UMggfbS8P/Evh1I xTwD+fGp1dbep9SDF5opB3KoQ2y53s6PczQks=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D8397FA0200007800037494@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acvlj5JuKyfkNpK3CkS4mvXABJFidg==
Thread-topic: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume
User-agent: Microsoft-Entourage/12.28.0.101117
On 18/03/2011 16:35, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> if ( !early_init_done ) {
>>  BUG_ON(smp_processor_id() != 0);
>>  ...
>>  early_init_done = 1;
>> }
>> 
>> It's clearer anyway -- we're simply protecting one-time-only early-boot-time
>> initialisation stuff.
> 
> What's wrong with doing the protection by passing down the
> necessary information?

Hm, yes, fair enough, I'll apply it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel