WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] input/xen-fbfront: advertise either absolute or

To: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] input/xen-fbfront: advertise either absolute or relative coordinates
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 15 Mar 2011 11:41:59 +0000
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "linux-input@xxxxxxxxxxxxxxx" <linux-input@xxxxxxxxxxxxxxx>
Delivery-date: Tue, 15 Mar 2011 04:43:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110315050024.GB1046@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1103111124400.2968@kaball-desktop> <20110313062411.GB31566@xxxxxxxxxxxxxxxxxxxxxx> <20110314100144.GA4572@xxxxxxxxx> <20110315050024.GB1046@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 15 Mar 2011, Dmitry Torokhov wrote:
> > Yes, as mentioned in the description above, using absolute coordinates in
> > the guests X11 is prefered because it avoids that the guest mouse
> > pointer gets out of sync with the host/desktop mouse pointer.
> > Very old Xen versions did not send absolute coordinates, but recent
> > versions do.
> > 
> 
> OK, as long as we have understanding that there is no concern with
> migrating to a version of hypervisor that does not support absolute
> coordinates reporting.
> 

Absolute coordinates have been present in xenfb since years now, so I
don't think is a concern anymore.


> BTW, I believe the code should be rearranged a bit, like in the patch
> below (this way we do not set up abs params if device works in relative
> mode).

Looks fine, thanks!
Would you be OK with carrying this patch in your tree or do you want me
to add it to mine?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel