Re: [Xen-devel] [PATCH] x86: force out-of-line instances of inline functions into .init.text in init-only code

[Keir Fraser <keir@xxxxxxx>]

On 11/03/2011 16:08, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Some compiler versions may choose to not inline certain functions,
> but the check introduced in c/s 23003:768269c43914 and applying to
> domain_build.o as of 23011:be7e54d86c57 wants .text to be empty.

Isn't this a possible problem for any file compiled under the rules of
obj-bin-y? If so, below should be defined for all such source files, perhaps
-D a macro def on $CC command line in that case (e.g., some obvious textual
macro name) and then pick up on that in <xen/compiler.h> to suitably
re-define inline and always_inline (and explain why in a code comment).

 -- Keir

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- 2011-03-09.orig/xen/arch/x86/domain_build.c
> +++ 2011-03-09/xen/arch/x86/domain_build.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #include <xen/config.h>
> +#define __inline__ __inline__ __init
>  #include <xen/init.h>
>  #include <xen/lib.h>
>  #include <xen/ctype.h>
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel