Re: [Xen-devel] [PATCH 0/5] x86: properly propagate errors to hy

To:	Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 0/5] x86: properly propagate errors to hypercall callee
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Fri, 11 Mar 2011 12:33:27 +0000
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 11 Mar 2011 04:34:20 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=oPSeDEbAE8dtmROE9j0Pc0dVhqtbPmwCUv8JRfZexz4=; b=PWdRAG/Lzz1fnGqpD9+xqT5o8WCROt24RtqHEiLeXgxwtmBEfIp/bPlXIXHWFAdSE6 ehzX3j76Z1SZLHmX+/VLmb9Mb/HdZZBJLAUUK4oPRCHG7BMEA0FClvYise908co3mtEr I29AdXeNhWzOqYPI8kN0FF2JDmy08ZilAzJKc=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=EYM8A42oP5HVYVT8v5X3+1lbsMIhMXEeCyxRATu//LSuT+3syR9QWzmmvyMxF/oQFk wjKmu99PBSL0q/Td8ai51y2GDm2KwLmP2ICJH0HxqgapmgdecfwsAvJHXA2BbNl9jq4/ SLwiPWOa7795U45g036tUstPzgm1BYQd/PLx8=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D7A0B120200007800035CB4@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acvf6IUuLloU2JrF3kWTZ/PEQ1QGkQ==
Thread-topic:	[Xen-devel] [PATCH 0/5] x86: properly propagate errors to hypercall callee
User-agent:	Microsoft-Entourage/12.28.0.101117

On 11/03/2011 10:44, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> ioremap() in general can fail, but failure of the writing the page
> table entries gets propagated to the caller only on the legacy
> kernels iirc (due to the lack of a return value of the accessor for
> pv-ops).
> 
> The problem at hand, however, is with the vm_insert_...()
> functions, which use set_pte_at(), which again has no return
> value, so it'll need to be the accessors themselves to
> 
> (a) never utilize the writeable page tables feature on any path
> that can alter cache attributes, and
> 
> (b) handle -ENOMEM from HYPERVISOR_update_va_mapping()
> and HYPERVISOR_mmu_update() (without knowing much about
> the context they're being called in).

I can't see changes like that getting upstream. Maybe okay if you're
prepared to carry the patch. Also I guess some callers may have trouble
handling the error no matter how far you punt it up the call chain.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 0/5] x86: properly propagate errors to hypercall