Re: [Xen-devel] [PATCH] fbfront: advertise either absolute or relative coordinates

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 10 Mar 2011, Eamon Walsh wrote:
> We have had an issue here where the "request-abs-pointer" key is appearing in 
> XenStore _after_ the backend has gone to the Connected state.  Qemu xenfb.c 
> checks for this key in the "connect()" callback, causing it to miss the key 
> and default to relative coordinates.
> 
> xen be: vkbd-0: frontend update: page-ref
> xen be: vkbd-0: frontend not ready (yet)
> xen be: vkbd-0: frontend update: page-gref
> xen be: vkbd-0: frontend not ready (yet)
> xen be: vkbd-0: frontend update: event-channel
> xen be: vkbd-0: frontend not ready (yet)
> xen be: vkbd-0: frontend state: Initialising -> Initialised
> xen be: vkbd-0: frontend update: state
> xen be: vkbd-0: bind evtchn port 53
> xen be: vkbd-0: ring ref 13, remote-port 11, local-port 53
> xen be: vkbd-0: backend state: InitWait -> Connected               <----
> xen be: vkbd-0: backend update: state
> xen be: vkbd-0: frontend update: request-abs-pointer               <----
> xen be: vkbd-0: frontend state: Initialised -> Connected
> xen be: vkbd-0: frontend update: state
> 
> 
> This could be a problem specific to our display server, and it only happens 
> sometimes. But we have been carrying the patch below in our xenfb.c.  It 
> makes sense to respond to a direct watch on the key itself instead of looking 
> for it at a state change.  This may be suitable for upstream to Qemu.
> 
> I also note that the check in Qemu was previously made even before the 
> connected state.  It was changed in July, see:
> http://web.archiveorange.com/archive/v/1XS1v5z9uIQLGujGBDhT
> 

The patch looks sane.
Could you please rebase it on upstream qemu and send it to qemu-devel?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel