|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for X
To: |
Daniel Kiper <dkiper@xxxxxxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver |
From: |
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |
Date: |
Wed, 9 Mar 2011 15:14:03 -0500 |
Cc: |
jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, dave@xxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, rientjes@xxxxxxxxxx, andi.kleen@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, wdauchy@xxxxxxxxx |
Delivery-date: |
Wed, 09 Mar 2011 12:15:58 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20110308215049.GH27331@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<20110308215049.GH27331@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
> - credit = current_target() - balloon_stats.current_pages;
> + credit = current_credit();
>
> - if (credit > 0)
> - state = increase_reservation(credit);
> + if (credit > 0) {
> + if (balloon_is_inflated())
> + state = increase_reservation(credit);
> + else
> + state = reserve_additional_memory(credit);
> + }
This code manipulation of where the current_target becomes current_credit
(and that logic) should be split off in its own patch.
Otherwise all the patches that touch Xen code look good.
>
> if (credit < 0)
> state = decrease_reservation(-credit);
> @@ -458,6 +594,14 @@ static int __init balloon_init(void)
> balloon_stats.retry_count = 1;
> balloon_stats.max_retry_count = 16;
>
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> + balloon_stats.hotplug_pages = 0;
> + balloon_stats.balloon_hotplug = 0;
> +
> + register_online_page_notifier(&xen_online_page_nb);
> + register_memory_notifier(&xen_memory_nb);
> +#endif
> +
> register_balloon(&balloon_sysdev);
>
> /*
> --
> 1.5.6.5
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|