WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some a

To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 08 Mar 2011 09:27:07 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 Mar 2011 01:27:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <b7eaf2bcdca1307bf4ec.1299497179@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1299497177@xxxxxxxxxxxxxxxxxxxxxxx> <b7eaf2bcdca1307bf4ec.1299497179@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>--- a/xen/arch/x86/x86_emulate/x86_emulate.c   Mon Mar 07 11:21:11 2011 +0000
>+++ b/xen/arch/x86/x86_emulate/x86_emulate.c   Mon Mar 07 11:21:11 2011 +0000
>@@ -2678,7 +2678,7 @@ x86_emulate(
>                 emulate_fpu_insn_memsrc("fiaddl", src.val);
>                 break;
>             case 1: /* fimul m64i */
>-                emulate_fpu_insn_memsrc("fimul", src.val);
>+                emulate_fpu_insn_memsrc("fimuls", src.val);

fimull.

>                 break;
>             case 2: /* ficom m64i */
>                 emulate_fpu_insn_memsrc("ficoml", src.val);

(Side note: The comments in this section are all wrong - they
should say "m32i"; there are no 64-bit integer operations
other than loads and stores.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>