[Xen-devel] Re: [PATCH] pvops: Make suspend work when CONFIG_SUSPEND=n

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

Thanks for this.

There has already been recent work on this, please see the threads "xen:
Use PM/Hibernate events for save/restore/chkpt" and "xen: fix
XEN_SAVE_RESTORE Kconfig dependencies" on both xen-devel and linux-pm.
AFAIK the conclusion is that an approach which ensures both
XEN_SAVE_RESTORE and SUSPEND (actually HIBERNATE after the above
discussion) are enable when necessary (by making the former depend on
the later) is what is going to be taken.

Ian.

On Fri, 2011-03-04 at 11:20 +0000, Frank Pan wrote:
> Recent pvops kernel fails on suspending some of devices on the
> following configuration:
> 
> CONFIG_SUSPEND=n
> CONFIG_PM_SLEEP=y
> 
> Command suspend on control/shutdown is recognized when
> CONFIG_PM_SLEEP=y. This indicates the device suspend logic should also
> be enabled on this configuration.
> The following patch works.
> ---
>  linux-2.6-xen/drivers/base/power/main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-2.6-xen/drivers/base/power/main.c
> b/linux-2.6-xen/drivers/base/power/main.c
> index 8aa2443..4d40fc4 100644
> --- a/linux-2.6-xen/drivers/base/power/main.c
> +++ b/linux-2.6-xen/drivers/base/power/main.c
> @@ -174,7 +174,7 @@ static int pm_op(struct device *dev,
>       int error = 0;
> 
>       switch (state.event) {
> -#ifdef CONFIG_SUSPEND
> +#if defined(CONFIG_SUSPEND) || defined(CONFIG_XEN_SAVE_RESTORE)
>       case PM_EVENT_SUSPEND:
>               if (ops->suspend) {
>                       error = ops->suspend(dev);
> @@ -238,7 +238,7 @@ static int pm_noirq_op(struct device *dev,
>       int error = 0;
> 
>       switch (state.event) {
> -#ifdef CONFIG_SUSPEND
> +#if defined(CONFIG_SUSPEND) || defined(CONFIG_XEN_SAVE_RESTORE)
>       case PM_EVENT_SUSPEND:
>               if (ops->suspend_noirq) {
>                       error = ops->suspend_noirq(dev);
> -- 
> 1.7.0.4
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel