[Xen-devel] Re: [GIT/PATCH v3] xen network backend driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2011-02-28 at 18:53 +0000, Ben Hutchings wrote:
> 
> > --- /dev/null
> > +++ b/drivers/net/xen-netback/common.h
> [...]
> > +     /* Statistics */
> > +     int rx_gso_checksum_fixup;
> 
> This should be defined as unsigned long (ideally it would be u64, but
> that can't be updated atomically on 32-bit systems). 

Thanks, I'll address all your comments in netback shortly but first I
guess xen-netfront also needs this:

Ian.


8<-----------------------------

>From d04fc6794249e26a5e5ba5fabf1456bb0e0309d2 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 1 Mar 2011 09:29:45 +0000
Subject: [PATCH] xen: netfront: ethtool stats fields should be unsigned long

Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
unsigned long as suggested by Ben Hutchings in
<1298919198.2569.14.camel@bwh-desktop>

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
---
 drivers/net/xen-netfront.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index a6ab973..df45323 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -122,7 +122,7 @@ struct netfront_info {
        struct mmu_update rx_mmu[NET_RX_RING_SIZE];
 
        /* Statistics */
-       int rx_gso_checksum_fixup;
+       unsigned long rx_gso_checksum_fixup;
 };
 
 struct netfront_rx_info {
-- 
1.5.6.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel