 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] tools: Handle failed xc_get_hvm_param in domain
| To: | George Dunlap <george.dunlap@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] tools: Handle failed xc_get_hvm_param in domain save |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Fri, 25 Feb 2011 17:25:15 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 25 Feb 2011 09:28:43 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <9261ae7a9a9c0ea748e8.1298558254@elijah> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <9261ae7a9a9c0ea748e8.1298558254@elijah> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
George Dunlap writes ("[Xen-devel] [PATCH] tools: Handle failed
xc_get_hvm_param in domain save"):
> The domain save code will read an HVM param, and if it's not zero,
> make an entry for it. However, if the hypercall fails for any reason,
> the data may not be written, and the value for the previous parameter
> may be written in the save file as the parameter that failed.
Thanks, I'm applying this.
But: what an unpleasantly formulaic section of code!
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] remus: fix incorrect disk_info_t initialization, Ian Jackson |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH qemu] Support grant references in mapping, Stefano Stabellini |
| Previous by Thread: | [Xen-devel] [PATCH] tools: Handle failed xc_get_hvm_param in domain save, George Dunlap |
| Next by Thread: | [Xen-devel] [PATCH] linux-2.6.18: make various _ATTR() definitions static, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
