WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 02/15] xen: Make xen build o

To: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 02/15] xen: Make xen build only on x86 target.
From: Anthony Liguori <anthony@xxxxxxxxxxxxx>
Date: Thu, 24 Feb 2011 11:59:25 -0600
Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>
Delivery-date: Thu, 24 Feb 2011 10:05:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D669977.2010507@xxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1296658172-16609-1-git-send-email-anthony.perard@xxxxxxxxxx> <1296658172-16609-3-git-send-email-anthony.perard@xxxxxxxxxx> <4D668346.4010903@xxxxxxxxxxxxx> <AANLkTimEBMzMYvcdCbvi1QJFCU0fP346fWJsOvwuM4+6@xxxxxxxxxxxxxx> <4D669507.3030509@xxxxxxxxxxxxx> <4D669977.2010507@xxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10
On 02/24/2011 11:46 AM, Jan Kiszka wrote:
On 2011-02-24 18:27, Anthony Liguori wrote:
On 02/24/2011 10:25 AM, Anthony PERARD wrote:
On Thu, Feb 24, 2011 at 16:11, Anthony Liguori<anthony@xxxxxxxxxxxxx>   wrote:

Is this really necessary?  The advantage to building globally is that it
keeps the code from getting unnecessary i386-isms.

Nop, is not necessary, I add this patch after this mail:
http://lists.nongnu.org/archive/html/qemu-devel/2010-12/msg00044.html

Alex, do you feel strongly here?
I'm not Alex, but I brought this issue up:

Either build xen bits once for all archs or restrict it to the only
foreseeable arch with support in qemu. But please don't built it for
each and every target separately.

Oh yes, I misunderstood. I thought we had previously built it for all architectures. Yes, we should only build it once.

Regards,

Anthony Liguori

BTW:

index b0ba95f..db29e96 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -206,7 +206,9 @@ QEMU_CFLAGS += $(VNC_JPEG_CFLAGS)
  QEMU_CFLAGS += $(VNC_PNG_CFLAGS)

  # xen backend driver support
-obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
+obj-$(CONFIG_XEN) += xen_backend.o xen_devconfig.o
+obj-$(CONFIG_XEN) += xen_console.o xenfb.o xen_disk.o xen_nic.o
+obj-i386-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
Why restricting the last line to i386? Doesn't CONFIG_XEN also control
here if the arch is xen-capable?

Thanks,
Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>