WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH v6] Userspace grant communication

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH v6] Userspace grant communication
From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Date: Mon, 14 Feb 2011 15:55:17 -0500
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx
Delivery-date: Mon, 14 Feb 2011 12:56:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110214192155.GD11121@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: National Security Agency
References: <1296753544-13323-1-git-send-email-dgdegra@xxxxxxxxxxxxx> <20110214161403.GB11034@xxxxxxxxxxxx> <20110214163855.GC11290@xxxxxxxxxxxx> <4D596CE9.4030900@xxxxxxxxxxxxx> <20110214192155.GD11121@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Thunderbird/3.1.7
On 02/14/2011 02:21 PM, Konrad Rzeszutek Wilk wrote:
>>>> And besides the two questions I posted today they look OK to me. However
>>>
>>> Oh, and Jeremy's comment about the WARN_ON on the copy_to_user..
>>>
>>
>> I did post an updated version of that patch without the bad WARN_ON. It still
>> resolves to a WARN_ON in all paths, but it's at a higher level.
> 
> Ah there it is. 
> 
> Look in git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git 
> stable/gntalloc.v6
> 
> [maybe in an hour - git.kernel.org takes a bit of time to resync to the 
> mirrors]
> to see if I am missing anything please.

9960be970cea52c1cb7d7c747ff6da367e1c01b5 looks good to me, nothing missing.

-- 
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel