Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 11 Feb 2011, Kamala Narasimhan wrote:
> Stefano Stabellini wrote:
> > On Thu, 10 Feb 2011, Kamala Narasimhan wrote:
> >> Stefano - This includes a fix for empty cdrom case issue you found while 
> >> testing.
> >>
> >> Description:
> >>
> >> This patch refactors xl disk specific interface to separate disk format 
> >> and backend types, rename some variables, changes code that is impacted by 
> >> this interface change.
> >>
> > 
> > you need to update the ocaml bindings, otherwise the patch will cause
> > build problems:
> > 
> > make[7]: Entering directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml/libs/xl'
> >  CC       xl_stubs.o
> > xl_stubs.c: In function 'device_disk_val':
> > xl_stubs.c:195: error: 'libxl_device_disk' has no member named 'physpath'
> > xl_stubs.c:196: error: 'libxl_device_disk' has no member named 'phystype'
> > xl_stubs.c:196: error: 'PHYSTYPE_QCOW' undeclared (first use in this 
> > function)
> > xl_stubs.c:196: error: (Each undeclared identifier is reported only once
> > xl_stubs.c:196: error: for each function it appears in.)
> > xl_stubs.c:197: error: 'libxl_device_disk' has no member named 'virtpath'
> > make[7]: *** [xl_stubs.o] Error 1
> > make[7]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml/libs/xl'
> > make[6]: *** [subdir-install-xl] Error 2
> > make[6]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml/libs'
> > make[5]: *** [subdirs-install] Error 2
> > make[5]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml/libs'
> > make[4]: *** [subdir-install-libs] Error 2
> > make[4]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml'
> > make[3]: *** [subdirs-install] Error 2
> > make[3]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools/ocaml'
> > make[2]: *** [subdir-install-ocaml] Error 2
> > make[2]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools'
> > make[1]: *** [subdirs-install] Error 2
> > make[1]: Leaving directory 
> > `/local/scratch/sstabellini/xen-unstable.hg/tools'
> > make: *** [install-tools] Error 2
> > 
> > 
> > apart from this it looks OK to me.
> 
> Stefano - Here is a revised patch that fixes the ocaml bindings build issues. 
>  While I confirmed that the build now works, I wouldn't even know where to 
> start when it comes to testing it!
> 
> Signed-off-by: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxxx>

The patch is OK for me.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel