WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "Zhang, Fengzhe" <fengzhe.zhang@xxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Wed, 9 Feb 2011 14:57:06 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: Keir, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Fraser <keir@xxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Tue, 08 Feb 2011 22:58:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D4695F0020000780002F6AC@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1A42CE6F5F474C41B63392A5F80372B231F18B24@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D4695F0020000780002F6AC@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvBLcXRTtQMQkc1QTOyvGfBXECbJwG99EnA
Thread-topic: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently
Jan Beulich wrote on 2011-01-31:
> How does this (namely the x2apic_enabled part) play together with the
> selection of the APIC driver, which in this case would have happened
> quite a bit earlier (from generic_apic_probe())?
> 
> I would therefore think that this change really belongs into
> check_x2apic_preenabled().

It is really a problem. But I do think we shall simply remove below line from 
check_x2apic_preenabled() fn:

         genapic = apic_x2apic_probe();

The same line exists in x2apic_bsp_setup() fn.

Jimmy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel