[Xen-devel] Re: [PATCH] xl: fix incorrect display of illegal option character

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andre Przywara writes ("[PATCH] xl: fix incorrect display of illegal option 
character"):
> according to the getopt(3) manpage (and to my testing) getopt returns 
> '?' if an unknown option character is found and stores the insulting 
> character in optopt.
> This patch fixes the broken output in such a situation:
...
> Please apply to 4.1.0-rc.

Done, thanks.

> By the way: some command parsers totally omit the faulting character and 
> just output "option not supported."
> Would you still accept a patch which turns all of those occurrences into 
> the upper, more verbose form?

Hrm, I'm not sure.  I guess if the patch is very very obvious.

> Especially as those conditions are not considered fatal and the command 
> execution continues anyway, I found it rather confusing to read an 
> unspecific error message without giving me a clue what I did wrong.

TBH I think it is a bug when unknown options are not fatal.  But
it's probably not sensible to change this now.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel