xen-devel
Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to
domain creation cleanup logic (domid values)"):
> On Thu, 27 Jan 2011, Ian Jackson wrote:
> > int libxl__domain_make(libxl_ctx *ctx, libxl_domain_create_info *info,
> > - uint32_t *domid)
> > + uint32_t *domid /* domid 0 or ~0 on entry; on exit
> > + valid, perhaps >0 (even on
> > error) */)
>
> can you please change this comment too?
What do you think would be clearer ? -1 isn't right since a
uint32_t can't have the value -1.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 2/6] libxl: fix error handling (xenstore transaction leak) in libxl__domain_make, (continued)
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Stefano Stabellini
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Ian Jackson
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Ian Jackson
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Gianni Tedesco
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Stefano Stabellini
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values),
Ian Jackson <=
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Stefano Stabellini
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Ian Jackson
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Stefano Stabellini
- Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values), Ian Jackson
|
|
|