WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xensec_tool: Fix for xc_interface_open() call

To: Daniel Kiper <dkiper@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xensec_tool: Fix for xc_interface_open() call
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 27 Jan 2011 18:00:36 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 27 Jan 2011 10:02:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110127161242.GA24844@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <20110127161242.GA24844@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-01-27 at 16:12 +0000, Daniel Kiper wrote: 
> Hi,
> 
> xc_interface_open() was called with improper number
> of arguments. It is fixed by this patch.
> 
> Daniel
> 
> # HG changeset patch
> # User dkiper@xxxxxxxxxxxx
> # Date 1296143465 -3600
> # Node ID 18f67003e804d4774fa27ddfd16177cc15538b7b
> # Parent  003acf02d416d657f750b7a7748fa8c5a932222c
> xc_interface_open() was called with improper number
> of arguments. It is fixed by this patch.
> 
> Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>

Appears to have been missed by 21483:779c0ef9682c. The interface change
also included the return type (int->xc_interface *) but that was already
covered in 21483.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r 003acf02d416 -r 18f67003e804 tools/security/secpol_tool.c
> --- a/tools/security/secpol_tool.c    Thu Jan 20 17:04:06 2011 +0000
> +++ b/tools/security/secpol_tool.c    Thu Jan 27 16:51:05 2011 +0100
> @@ -511,7 +511,7 @@ int main(int argc, char **argv)
>          if (argc != 2)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }
> @@ -523,7 +523,7 @@ int main(int argc, char **argv)
>          if (argc != 3)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }
> @@ -535,7 +535,7 @@ int main(int argc, char **argv)
>          if (argc != 2)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>