WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH V9 09/16] xen: add a 8259 Interrupt

To: Anthony Liguori <anthony@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V9 09/16] xen: add a 8259 Interrupt Controller
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Thu, 27 Jan 2011 17:19:24 +0000 (GMT)
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 27 Jan 2011 09:20:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D40A864.6040603@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1295965760-31508-1-git-send-email-anthony.perard@xxxxxxxxxx> <1295965760-31508-10-git-send-email-anthony.perard@xxxxxxxxxx> <4D40A864.6040603@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Wed, 26 Jan 2011, Anthony Liguori wrote:

> On 01/25/2011 08:29 AM, anthony.perard@xxxxxxxxxx wrote:
> > From: Anthony PERARD<anthony.perard@xxxxxxxxxx>
> >
> > Introduce a 8259 Interrupt Controller for target-xen; every set_irq
> > call makes a Xen hypercall.
> >
> > Signed-off-by: Anthony PERARD<anthony.perard@xxxxxxxxxx>
> > Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
> > ---
> >   hw/xen_common.h     |    2 ++
> >   hw/xen_machine_fv.c |    5 ++---
> >   xen-all.c           |   12 ++++++++++++
> >   3 files changed, 16 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/xen_common.h b/hw/xen_common.h
> > index b98d107..0cc935a 100644
> > --- a/hw/xen_common.h
> > +++ b/hw/xen_common.h
> > @@ -42,4 +42,6 @@ static inline int xc_fd(xc_interface *xen_xc)
> >   }
> >   #endif
> >
> > +qemu_irq *i8259_xen_init(void);
> > +
> >   #endif /* QEMU_HW_XEN_COMMON_H */
> > diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c
> > index 2f51625..0a90312 100644
> > --- a/hw/xen_machine_fv.c
> > +++ b/hw/xen_machine_fv.c
> > @@ -37,6 +37,7 @@
> >   #include "xen_common.h"
> >   #include "xen/hvm/hvm_info_table.h"
> >   #include "xen_platform.h"
> > +#include "xen_common.h"
> >
> >   #define MAX_IDE_BUS 2
> >
> > @@ -52,7 +53,6 @@ static void xen_init_fv(ram_addr_t ram_size,
> >       PCIBus *pci_bus;
> >       PCII440FXState *i440fx_state;
> >       int piix3_devfn = -1;
> > -    qemu_irq *cpu_irq;
> >       qemu_irq *isa_irq;
> >       qemu_irq *i8259;
> >       qemu_irq *cmos_s3;
> > @@ -76,8 +76,7 @@ static void xen_init_fv(ram_addr_t ram_size,
> >       env = cpu_init(cpu_model);
> >       env->halted = 1;
> >
> > -    cpu_irq = pc_allocate_cpu_irq();
> > -    i8259 = i8259_init(cpu_irq[0]);
> > +    i8259 = i8259_xen_init();
> >       isa_irq_state = qemu_mallocz(sizeof (*isa_irq_state));
> >       isa_irq_state->i8259 = i8259;
> >
> > diff --git a/xen-all.c b/xen-all.c
> > index 8a51873..205cbc4 100644
> > --- a/xen-all.c
> > +++ b/xen-all.c
> > @@ -43,6 +43,18 @@ void xen_piix_pci_write_config_client(uint32_t address, 
> > uint32_t val, int len)
> >       }
> >   }
> >
> > +/* i8259 */
> > +
> > +static void i8259_set_irq(void *opaque, int irq, int level)
> > +{
> > +    xc_hvm_set_isa_irq_level(xen_xc, xen_domid, irq, level);
> > +}
> > +
> > +qemu_irq *i8259_xen_init(void)
> > +{
> > +    return qemu_allocate_irqs(i8259_set_irq, NULL, 16);
> > +}
> > +
> >
>
>
> I think it would make more sense to just call it a Xen interrupt
> controller as it's clearly not an i8259.  Xen may emulate an i8259 in
> the kernel but this has nothing to do with that AFAIK.
>
> Regards,
>
> Anthony Liguori

I will do that.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>