WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hyperc

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Wed, 26 Jan 2011 13:47:44 +0000 (GMT)
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 26 Jan 2011 05:48:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110126024924.GA25296@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1295965760-31508-1-git-send-email-anthony.perard@xxxxxxxxxx> <1295965760-31508-17-git-send-email-anthony.perard@xxxxxxxxxx> <20110126024924.GA25296@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Wed, 26 Jan 2011, Isaku Yamahata wrote:

> On Tue, Jan 25, 2011 at 02:29:20PM +0000, anthony.perard@xxxxxxxxxx wrote:
> > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > ---
> >  hw/acpi_piix4.c |    4 ++++
> >  hw/xen.h        |    2 ++
> >  xen-all.c       |    7 +++++++
> >  xen-stub.c      |    4 ++++
> >  4 files changed, 17 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> > index 5bbc2b5..ea94bf9 100644
> > --- a/hw/acpi_piix4.c
> > +++ b/hw/acpi_piix4.c
> > @@ -23,6 +23,7 @@
> >  #include "acpi.h"
> >  #include "sysemu.h"
> >  #include "range.h"
> > +#include "xen.h"
> >
> >  //#define DEBUG
> >
> > @@ -181,6 +182,9 @@ static void pm_ioport_write(IORange *ioport, uint64_t 
> > addr, unsigned width,
> >                      if (s->cmos_s3) {
> >                          qemu_irq_raise(s->cmos_s3);
> >                      }
> > +                    if (xen_enabled()) {
> > +                        xen_set_hvm_sleep_state();
> > +                    }
> >                  default:
> >                      break;
> >                  }
>
> Why not utilize cmos_s3 callback?
> Something like
>
> -       cmos_s3 = qemu_allocate_irqs(pc_cmos_set_s3_resume, rtc_state, 1);
> +       cmos_s3 = qemu_allocate_irqs(xen_cmos_set_s3_resume, rtc_state, 1);
>         smbus = piix4_pm_init(pci_bus, piix3_devfn + 3, 0xb100,
>                               isa_reserve_irq(9), *cmos_s3, *smi_irq,
>                               kvm_enabled());
>
>
> xen_cmos_set_s3_resume()
>       pc_cmos_set_s3_resume()
>       xen_set_hvm_sleep_state()
>
>
> thanks,

I will do that and resend the patch. Thanks for this!

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>