WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: p2m: correctly initialize partial p2m leave

To: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: p2m: correctly initialize partial p2m leave
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 25 Jan 2011 16:54:32 +0000
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Tue, 25 Jan 2011 08:55:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D3848DF.9000906@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <4D3848DF.9000906@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Please always include an inline copy of a patch for easier
review-by-reply, even if you also include an attachment because your
mailer mangles patches.

Anyway, I suspect the following comment is obsoleted by Jeremy's "just
do it in place" suggestion but:

On Thu, 2011-01-20 at 14:38 +0000, Stefan Bader wrote:
> [...]
> +                       unsigned long **p2m = extend_brk(PAGE_SIZE, 
> PAGE_SIZE);

I think this would need to be matched by a corresponding RESERVE_BRK of some 
sort.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel