WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]tools:xl: Fix for Windows UP crash on boot using

To: "Zhang, Fengzhe" <fengzhe.zhang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]tools:xl: Fix for Windows UP crash on boot using xl
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 21 Jan 2011 17:05:51 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 21 Jan 2011 09:05:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1A42CE6F5F474C41B63392A5F80372B231F18B25@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1A42CE6F5F474C41B63392A5F80372B231F18B25@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 21 Jan 2011, Zhang, Fengzhe wrote:
> tools:xl: Fix for Windows UP crash on boot using xl
> 
> When parameter "vcpus" is not explicitly set in config file, cur_vpus is 
> initialized to 0 instead of 1, which causes domU crash.
> 

Thanks for debugging this!
The code you are changing below has been moved to
tools/libxl/libxl_create.c.
Could you please refresh your patch?


> Signed-off-by: Fengzhe Zhang <fengzhe.zhang@xxxxxxxxx>
> 
> diff -r 7b4c82f07281 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Wed Jan 05 23:54:15 2011 +0000
> +++ b/tools/libxl/xl_cmdimpl.c        Fri Jan 21 23:52:35 2011 +0800
> @@ -328,6 +328,7 @@
>  {
>      memset(b_info, '\0', sizeof(*b_info));
>      b_info->max_vcpus = 1;
> +    b_info->cur_vcpus = 1;
>      b_info->max_memkb = 32 * 1024;
>      b_info->target_memkb = b_info->max_memkb;
>      b_info->disable_migrate = 0;
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>