WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix pygrub --isconfig

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix pygrub --isconfig
From: John Haxby <john.haxby@xxxxxxxxxx>
Date: Fri, 21 Jan 2011 15:20:40 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 21 Jan 2011 07:21:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19768.25958.450244.247435@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D385A40.9090908@xxxxxxxxxx> <19768.25958.450244.247435@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7
On 20/01/11 16:40, Ian Jackson wrote:
> John Haxby writes ("[Xen-devel] [PATCH] Fix pygrub --isconfig"):
>> Recentlly, when trying to get to the bottom of some strange booting
>> problem, I discovered that
>>
>>     pyrgub --isconfig <image file>
>>
>> usefully reports the kernel, initrd (ramdisk) and arguments that would
>> be used to boot a kernel.  Well, actually, what it reported was an
>> error.  This patch makes it work (and jolly useful it is too).  The
>> patch also removes a spurious "print >>sys.stderr" that seems to have
>> been left in from some previous debugging.
> Thanks, but this patch doesn't apply to xen-unstable.hg.  xen-unstable
> has a loop "for offset in part_offs" surrounding the code you seem to
> be trying to patch.

Sorry.  This patch was originally from something rather older which I
then applied to xen-4.0-testing by mistake.
I have attached an updated patch against xen-unstable.hg.
> Is it important to check for "isconfig" before running sniff_solaris
> and sniff_netware ?

No, it should really be checked after as (presumably) the intention is
to report what would actually be chosen.

Although I have attached the patch to move the isconfig stuff to the
point where the chosenconfig is finally known "pygrub --isconfig" is
functionally equivalent to "pygrub --not-really --output-format simple
--output -" so it might be better just to remove the isconfig code
altogether.  You could make it a synonym for the longer command, but as
isconfig has been unloved for quite a while it probably isn't worth it.

jch

Attachment: pygrub.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>