WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/5] change the name of the qemu save file at res

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/5] change the name of the qemu save file at restore time
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 20 Jan 2011 15:12:53 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Jan 2011 07:13:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1101191245140.7277@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <alpine.DEB.2.00.1101191245140.7277@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Stefano Stabellini writes ("[Xen-devel] [PATCH 1/5] change the name of the qemu 
save file at restore time"):
> Change the name of the qemu save file to qemu-resume at restore time so
> that it doesn't collide with the name of the next save file.
...
> -    sprintf(path, "/var/lib/xen/qemu-save.%u", dom);
> +    sprintf(path, "/var/lib/xen/qemu-resume.%u", dom);
...
> -                       "/var/lib/xen/qemu-save.%d", domid);
> +                       RESTOREFILE".%d", domid);
...
> +#define SAVEFILE "/var/lib/xen/qemu-save"
> +#define RESTOREFILE "/var/lib/xen/qemu-resume"

Uh, why is the latter not in libxc so that libxc can use it too ?

> -            args = args + ([ "-loadvm", "/var/lib/xen/qemu-save.%d" %
> +            args = args + ([ "-loadvm", "/var/lib/xen/qemu-resume.%d" %

At least this has some kind of excuse.  It's probably too painful to
do anything else but keep the 2nd hardcoded value (and anyway this is
in xend).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel