Re: [Xen-devel] [PATCH] hotplug: allow hardlinked files for bloc

Olaf Hering writes ("[Xen-devel] [PATCH] hotplug: allow hardlinked files for 
block device images"):
> Without this change, $dev would contain /dev/loop8\n/dev/loop10
> Applies to 4.0 and 4.1

Thanks.  I have applied this to xen-unstable.hg.  I'm always a bit suspicious
of hotplug script changes, so we'll wait with backporting it to see if
it doesn't cause immediate trouble ...

Paolo Bonzini writes ("[Xen-devel] Re: [PATCH] hotplug: allow hardlinked files 
for block device images"):
> On 01/17/2011 04:57 PM, Olaf Hering wrote:
> > I'm sure there are pathnames which break the regex in some way.
> > Adding an escape for '@' could be added, for example.
> >
> > How well can the rest of Xen cope with odd filenames? In other words,
> > does it even get there if the configured pathnames have odd chars in it?
> 
> @ is definitely not so odd...

Yes, this is a good point.  However, I think the patch as it stands is
an improvement.  Feel free to submit changes to make it more robust
:-).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH 1/1] qemu-xen/blkif: Move read/write/barrier specific fields into a union, Ian Jackson

Next by Date:

Re: [Xen-devel] xl destroy, Ian Jackson

Previous by Thread:

[Xen-devel] Re: [PATCH] hotplug: allow hardlinked files for block device images, Paolo Bonzini

Next by Thread:

[Xen-devel] [PATCH 0/6] xenpaging changes for xen-4.1, Olaf Hering

Indexes:

[Date] [Thread] [Top] [All Lists]