WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk f

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file
From: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Date: Fri, 14 Jan 2011 12:17:01 -0500
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 14 Jan 2011 09:21:27 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=KKt9KrWKOxCyqX4SKIF6TqS0MgLsZs/UTD0FtuSs9S8=; b=L2bWj+HSiALd7Hjs4r5LScHh8oKhrBStTIZ0/K7knFaLs4SJZvcaDVGjw++CbLbGd+ FFPIPsUCSWMVG/HzGJV3lsrN2rk8ntyFFUHkJoUnGUWRL2yHNTr2yPoH4+AwPfG0atgN 5+8plxVm4YIjnu2woct1FedDH7YsEBgXliW/I=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=DJ277q/5Gmmzj4MLmgD3Y2OdkwKo27ZZuOmbWJi3Ft+X4+DWBzWpP6YcknfKtjgBc6 XER9i4tdgQYyIWS60dByDvXRON8I7A85FYsCtfomg2GdhEx0U5yUUlTCVH4UQcn2X630 gLLXLLWgvx9xQ1CFQJYDS2cB3l7c2pVl4szYw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1295024348.12018.222.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTimSUym0u+SNm0AvNp3AZQQFspetAaXmNShkPJd4@xxxxxxxxxxxxxx> <1294995912.8240.86.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikfUHHc+-gVkgnRJc722wObLF3TumpK5WSfJVAE@xxxxxxxxxxxxxx> <1295024348.12018.222.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> I think Ians point is that your change affects the 'xl' binary and not
> the libxl.so library.
>
Ah!  I mistook it then.

> Perhaps libxl_device_disk_add() and libxl_cdrom_insert() would be the
> reasonable places to add this, replacing fprintf() calls with libxl
> logging functions.
>
I will make necessary changes and resend the patch.

Kamala

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>