Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.

Ian Jackson wrote:
> Jim Fehlig writes ("Re: [Xen-devel] Last call for forgotten tools patches for 
> Xen 4.1"):
>   
>> Sorry for the delay, but I just noticed this tools patch submitted by
>> Chun Yan back in November
>>
>> http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01559.html
>>     
>
> Thanks.  I replied to that but there was no updated patch.
>   

Opps, I thought Chunyan had sent an updated patch but perhaps have
confused this with her qemu keysym patches.

> Now that I look at the patch again I see some other problems:
>  * It closes the fd onto the file after locking it with flock (!)
>  * On success it unlinks the lock file after locking it (!!)
>  * The error return value is wrong (or perhaps it was wrong before).
>   

Err, right.  And there was no follow-up as I assumed.  Chunyan, can you
address Ian's comments and submit an updated patch?

Thanks,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Xen 4.1.0 RC1 released, Keir Fraser

Next by Date:

[Xen-devel] Re: [PATCH] mem_sharing: fix race condition of nominate and unshare, Tim Deegan

Previous by Thread:

Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1, Ian Jackson

Next by Thread:

[Xen-devel] [xen-unstable test] 4595: regressions - FAIL, xen . org

Indexes:

[Date] [Thread] [Top] [All Lists]