WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xl: save domain config (userdata) under correct

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] xl: save domain config (userdata) under correct domid/uuid
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 13 Jan 2011 01:28:08 +0000
Delivery-date: Wed, 12 Jan 2011 17:29:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19758.17728.154557.537487@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19758.17728.154557.537487@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I wrote:
> I think this is fixed by the patch below, which I have just applied.

Um, but, I missed a bit.

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1294882004 0
# Node ID ce208811f5401dcc6dc39a1e592b102e8d3e7c85
# Parent  d839631b604807fe0f978f9eacc1c73f6a9bf0bd
xl: correct test for domid on error exit from domain_create

The previous changeset 22739:d839631b6048 changed the initialisation
of domid without changing the corresponding cleanup test.  Oops.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r d839631b6048 -r ce208811f540 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Thu Jan 13 00:18:35 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c  Thu Jan 13 01:26:44 2011 +0000
@@ -1627,7 +1627,7 @@ start:
 
 error_out:
     release_lock();
-    if (domid)
+    if (domid > 0)
         libxl_domain_destroy(&ctx, domid, 0);
 
 out:

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>