| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 2/7] xen-gntdev: Change page limit to be global i
On 01/10/2011 04:52 PM, Konrad Rzeszutek Wilk wrote:
>> static long gntdev_ioctl(struct file *flip,
>> unsigned int cmd, unsigned long arg)
>> {
>> @@ -555,9 +538,6 @@ static long gntdev_ioctl(struct file *flip,
>> case IOCTL_GNTDEV_GET_OFFSET_FOR_VADDR:
>> return gntdev_ioctl_get_offset_for_vaddr(priv, ptr);
>>
>> - case IOCTL_GNTDEV_SET_MAX_GRANTS:
>> - return gntdev_ioctl_set_max_grants(priv, ptr);
>
> Would it make sense to return -EPNOTSUPPORTED? Or does it not really
> matter as nobody has been using this ioctl call?
Does this produce a clearer error message than the default -ENOIOCTLCMD?
It's possible that some people use it, since it was exposed as an API.
Doesn't really matter to me; we could also have it return 0 and be a
noop in case someone interprets its failure as inability to support a
sufficient number of grants.
>> -
>> default:
>> if (debug)
>> printk("%s: priv %p, unknown cmd %x\n",
>> --
>> 1.7.2.3
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home