Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing

To:	"Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Mon, 10 Jan 2011 10:52:54 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date:	Mon, 10 Jan 2011 01:54:05 -0800
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1294653193; l=738; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=ps6Ld9RRZcwLr9d1F5r9LVy7TJg=; b=yvOcEkt9v8wD1AZSYVfO/Mm/JLp/xAYdYHhBS61o/Ts1JPSV13L3cPbieoBYBv6m8CQ pT4W8ZC2dZT3PHxnEsRLT+SBjcZmDflg1Q8ur+IsUm5TmQqr01D2KXoNlmBFtGENKtqkr nuYlUd39eK+fwKKaDNHadASiQTGLyX/YjK4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<987664A83D2D224EAE907B061CE93D53019401026E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<987664A83D2D224EAE907B061CE93D530193FC6195@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D258EB2020000780002AA9F@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D53019400FE55@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D26DBF1020000780002AEF5@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D53019401026E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.20 (2009-06-14)

On Fri, Jan 07, Kay, Allen M wrote:

> >@@ -548,17 +533,12 @@ static int inline iommu_flush_iotlb_psi(
> >     if ( !cap_pgsel_inv(iommu->cap) )
> >         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry, 
> > flush_dev_iotlb);
> > 
> >-    /*
> >-     * PSI requires page size is 2 ^ x, and the base address is naturally
> >-     * aligned to the size
> >-     */
> >-    align = get_alignment(addr >> PAGE_SHIFT_4K, pages);
> >     /* Fallback to domain selective flush if size is too big */
> >-    if ( align > cap_max_amask_val(iommu->cap) )
> >+    if ( order > cap_max_amask_val(iommu->cap) )

This leaves 'align' uninitialized when flush->iotlb() is called.

iommu.c:546: error: 'align' may be used uninitialized in this function


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing