Re: [Xen-devel] [PATCH] add placeholder for packet extension to block interface

[Keir Fraser <keir@xxxxxxx>]

On 22/12/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> While the corresponding implementation has been in our trees for quite
> a while, it's in a state that doesn't make it suitable for submission,
> and the original author having left the company leaves open to find
> someone to complete this work. Yet to prevent problems with other
> interface extensions we'd like to keep the slot in the number space
> reserved for the purpose it has been serving here.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -76,6 +76,10 @@
>   * "feature-flush-cache" node!
>   */
>  #define BLKIF_OP_FLUSH_DISKCACHE   3
> +/*
> + * Device specific command packet contained within the request
> + */
> +#define BLKIF_OP_PACKET            4

Without more details, perhaps it would be better to call this
BLKIF_OP_RESERVED_1 or BLKIF_OP_RESERVED_NOVELL. It makes it clearer what is
going on (used internally by Novell for feature not yet submitted upstream),
and the name can be changed to BLKIF_OP_PACKET if the support ever gets
cleaned up and accepted.

 -- Keir

>  /*
>   * Maximum scatter/gather segments per request.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel