WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] add placeholder for packet extension to block in

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] add placeholder for packet extension to block interface
From: Keir Fraser <keir@xxxxxxx>
Date: Wed, 22 Dec 2010 11:19:27 +0000
Cc:
Delivery-date: Wed, 22 Dec 2010 03:20:36 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=Zdaz1PIFx5oTl37F8BLGPeChy9I+UEKYkLYrmf4YnNs=; b=cPu/0jU7LsRtpDLRnRHshHX2DBE/e2Y9WdQS3djj8CNRpFK2dKhEbi9OwWD/dqQTla Sh0LXPtMkPRgeFsHfHvotXenUe1+B2n4qcmKT4JpAHbEi5g4yOLeurPtQjsemOl1+2UV yo+Ldd4QUFsTu2PdvnUiTjSrIlrs7qDDaXPoU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=mbsui8INRsfvLYKUhuIX828IS8ywf/77Y2DILwk35WFi4Qele5vWbyFUFTEKCgEtZz UQ1VgAP+rV/D+9NFiikxJ8dUyz7HEIJFa+FmvQuifWxHEvlfqhGNxjj9D9d815HM48bE kb45yCJE292e/j8oarSB+oJ6+lGq89ssWqykA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D11DCB30200007800029497@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuhyhgZqYDH+iK+KECWs6kbTNpQGQ==
Thread-topic: [Xen-devel] [PATCH] add placeholder for packet extension to block interface
User-agent: Microsoft-Entourage/12.28.0.101117
On 22/12/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> While the corresponding implementation has been in our trees for quite
> a while, it's in a state that doesn't make it suitable for submission,
> and the original author having left the company leaves open to find
> someone to complete this work. Yet to prevent problems with other
> interface extensions we'd like to keep the slot in the number space
> reserved for the purpose it has been serving here.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -76,6 +76,10 @@
>   * "feature-flush-cache" node!
>   */
>  #define BLKIF_OP_FLUSH_DISKCACHE   3
> +/*
> + * Device specific command packet contained within the request
> + */
> +#define BLKIF_OP_PACKET            4

Without more details, perhaps it would be better to call this
BLKIF_OP_RESERVED_1 or BLKIF_OP_RESERVED_NOVELL. It makes it clearer what is
going on (used internally by Novell for feature not yet submitted upstream),
and the name can be changed to BLKIF_OP_PACKET if the support ever gets
cleaned up and accepted.

 -- Keir

>  /*
>   * Maximum scatter/gather segments per request.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>