|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 05/10] xen/setup: Set identity mapping for non-RA
To: |
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH 05/10] xen/setup: Set identity mapping for non-RAM E820 and E820 gaps. |
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
Date: |
Wed, 22 Dec 2010 08:49:33 +0000 |
Cc: |
"jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Rzeszutek Wilk <konrad@xxxxxxxxxx>, Konrad, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx> |
Delivery-date: |
Wed, 22 Dec 2010 00:50:36 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<1292967460-15709-6-git-send-email-konrad.wilk@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Organization: |
Citrix Systems, Inc. |
References: |
<1292967460-15709-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1292967460-15709-6-git-send-email-konrad.wilk@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Tue, 2010-12-21 at 21:37 +0000, Konrad Rzeszutek Wilk wrote:
> @@ -254,6 +282,12 @@ char * __init xen_memory_setup(void)
>
> xen_add_extra_mem(extra_pages);
>
> + /*
> + * Set P2M for all non-RAM pages and E820 gaps to be identity
> + * type PFNs.
> + */
> + printk(KERN_INFO "Set %ld page(s) to 1-1 mapping.\n",
> + xen_set_identity(&e820));
I had to look at this patch twice to find the caller of the
xen_set_identity function here. I think spending a variable here would
be worth the improved clarity.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 06/10] xen/setup: Only set identity mapping in E820 regions when privileged., (continued)
|
|
|
|
|