| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon featu
|
To: |
Daniel Kiper <dkiper@xxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes |
|
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
|
Date: |
Mon, 20 Dec 2010 14:51:44 +0000 |
|
Cc: |
"jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "haicheng.li@xxxxxxxxxxxxxxx" <haicheng.li@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "v.tolstov@xxxxxxxxx" <v.tolstov@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "andi.kleen@xxxxxxxxx" <andi.kleen@xxxxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "fengguang.wu@xxxxxxxxx" <fengguang.wu@xxxxxxxxx> |
|
Delivery-date: |
Mon, 20 Dec 2010 06:53:43 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20101220134724.GC6749@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Citrix Systems, Inc. |
|
References: |
<20101220134724.GC6749@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Mon, 2010-12-20 at 13:47 +0000, Daniel Kiper wrote:
> Features and fixes:
> - HVM mode is supported now,
> - migration from mod_timer() to schedule_delayed_work(),
> - removal of driver_pages (I do not have seen any
> references to it),
> - protect before CPU exhaust by event/x process during
> errors by adding some delays in scheduling next event,
> - some other minor fixes.
Each of those bullets should be a separate patch (or several if
appropriate). I didn't review most of the rest because it mixed so much
stuff together but a couple of minor things jumped out.
> -static void scrub_page(struct page *page)
> +static inline void scrub_page(struct page *page)
Is there some reason we need to override the compiler's decision here?
There is some discussion of the (over)use of inline in CodingStyle.
> static struct attribute_group balloon_info_group = {
> .name = "info",
> - .attrs = balloon_info_attrs,
> + .attrs = balloon_info_attrs
> };
>
> static struct sysdev_class balloon_sysdev_class = {
> - .name = BALLOON_CLASS_NAME,
> + .name = BALLOON_CLASS_NAME
> };
I don't think there is anything wrong with the existing style here.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home