 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] do_memory_op: cleanup if copy_to_guest fails
| To: | Keir Fraser <keir@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] do_memory_op: cleanup if copy_to_guest fails |
| From: | Olaf Hering <olaf@xxxxxxxxx> |
| Date: | Thu, 16 Dec 2010 20:18:59 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 16 Dec 2010 11:22:04 -0800 |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1292527142; l=467; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=gMV/QyO4WzkyYUdhSFFzGPh4aj4=; b=URCRK27lNTMM1/2iAG+CEYVJOnxlANf8+HLFdvzQ1+25orAGbDW9dM3pI/M2kTxJRMG elkAcy0LueOwyMh8mHW5S+RMmNWK/B6Ng0WYbno0x7fbRNY/7yNLL2IhGoMQArvG/8Lr5 8BaCEE7qf+c8pu/tJHYpbMc2Wf5T+khpB7w= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C9300BAE.29659%keir@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20101216175910.GA24006@xxxxxxxxx> <C9300BAE.29659%keir@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Thu, Dec 16, Keir Fraser wrote: > Leaving a bit of a mess on failed copy_to_guest is okay imo, as that is > usually a pretty fatal sign anyway. If there were good reason for cleaning > up better, we should at least be doing if (test_and_clear(PGC_allocated)) > put_page(). Yes, it would leak just a page and from what I have seen, the Linux drivers will BUG() most of the time anyway if the hypercall fails. So I will drop this from my series. Olaf _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-users] Re: [Xen-devel] Re: Xen 4.0.1 failed to compile on Ubuntu Natty 32 bits, Olaf Hering |
|---|---|
| Next by Date: | [Xen-devel] Xen 4.0.1 "xc_map_foreign_batch: mmap failed: Cannot allocate memory", Charles Arnold |
| Previous by Thread: | Re: [Xen-devel] [PATCH] do_memory_op: cleanup if copy_to_guest fails, Keir Fraser |
| Next by Thread: | [Xen-devel] Xen 4.0.1 "xc_map_foreign_batch: mmap failed: Cannot allocate memory", Charles Arnold |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
