WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xenalyze: use correct sizeof argument when counting

To: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xenalyze: use correct sizeof argument when counting extra_data
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 16 Dec 2010 11:35:45 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 16 Dec 2010 02:36:53 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1292495752; l=687; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=QbX4r3U4DlTEfNMoFdpHcC2zypc=; b=WLtvdmYRHVv8CE9wYecToa+5Ly1Qsc98KMdbWEr3+Uky2M0ktbiia9Ny1kBCRQM8Ne1 UApC7E4p4BikFrY6JbbzTORVcl6621103BHM9mxDjnO1ksk/cmf0U2xmlsfCF0E6h+l5z A5+W8nlsygOxb5+0vL/2HSy2/nWvaB5qWZg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101214174620.GA19442@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101214174620.GA19442@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
tracedata are units of u32, so make sure the sizeof() gets the correct
argument.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

--- xenalyze.hg.orig/xenalyze.c
+++ xenalyze.hg/xenalyze.c
@@ -3588,12 +3588,12 @@ void hvm_mmio_assist_process(struct reco
     if(mevt.x64) {
         e->gpa = r->x64.gpa;
         e->data = r->x64.data;
-        if(ri->extra_words*(sizeof(unsigned long))==sizeof(r->x64))
+        if(ri->extra_words*(sizeof(unsigned int))==sizeof(r->x64))
             e->mmio_data_valid=1;
     } else {
         e->gpa = r->x32.gpa;
         e->data = r->x32.data;
-        if(ri->extra_words*(sizeof(unsigned long))==sizeof(r->x32))
+        if(ri->extra_words*(sizeof(unsigned int))==sizeof(r->x32))
             e->mmio_data_valid=1;
     }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>