xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before u

from [Jan Beulich]

[Permanent Link][Original]

To:	"Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only)
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Thu, 16 Dec 2010 08:04:39 +0000
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 16 Dec 2010 00:05:44 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D093F57.7030809@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4D08AB71020000780002813F@xxxxxxxxxxxxxxxxxx> <4D093F57.7030809@xxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>> On 15.12.10 at 23:21, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> On 12/15/2010 02:50 AM, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>>
>> --- a/xen/arch/x86/x86_64/compat/entry.S
>> +++ b/xen/arch/x86/x86_64/compat/entry.S
>> @@ -25,7 +25,8 @@ ENTRY(compat_hypercall)
>>          pushq UREGS_rbx(%rsp); pushq %rcx; pushq %rdx; pushq %rsi; pushq 
> %rdi
>>          pushq UREGS_rbp+5*8(%rsp)
>>          leaq  compat_hypercall_args_table(%rip),%r10
>> -        movq  $6,%rcx
>> +        movl  %eax,%eax
>> +        movl  $6,%ecx
> 
> Is the second line part of the fix, or just a drive-by tweak?

The latter (sorry, I couldn't withstand, as I was surprised I
didn't do so when I created this code as a clone of its native
counterpart).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only), Jan Beulich Re: [Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only), Jeremy Fitzhardinge Re: [Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only), Jan Beulich <=

Previous by Date:	Re: [Xen-devel] Re: Panic on cpu0, Pasi Kärkkäinen
Next by Date:	Re: [Xen-devel] [PATCH] svm: support VMCB cleanbits, Keir Fraser
Previous by Thread:	Re: [Xen-devel] [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only), Jeremy Fitzhardinge
Next by Thread:	[Xen-devel] [PATCH] svm: support VMCB cleanbits, Christoph Egger
Indexes:	[Date] [Thread] [Top] [All Lists]