| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 4/6] xen-gntdev: Use find_vma rather than iterati
On Tue, 2010-12-14 at 21:20 +0000, Jeremy Fitzhardinge wrote:
> On 12/14/2010 06:55 AM, Daniel De Graaf wrote:
> > @@ -74,6 +74,8 @@ struct grant_map {
> > struct granted_page pages[0];
> > };
> >
> > +static struct vm_operations_struct gntdev_vmops;
>
> Is it OK for this to be all NULL?
It's a forward declaration, the actual definition is later on.
I think it would be clearer to move the existing declaration (plus
gntdev_vma_{close,fault}) before gntdev_ioctl_get_offset_for_vaddr or
vice versa.
Oh wait, gntdev_ioctl_get_offset_for_vaddr is already after
gntdev_vmops, isn't it? Unless it changed in patches 2 or 3 which I
don't think it did?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home