Re: [Xen-devel] [PATCH] Re-define PKT_PROT_LEN to be bigger.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2010-12-14 at 20:35 +0000, Paul Durrant wrote:
> Re-define PKT_PROT_LEN to be big enough to handle maximal IPv4 and TCP 
> options and phrase
> the definition so that it's reasonably obvious that's what it's for.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  drivers/xen/netback/netback.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
> index c448675..1a4a20e 100644
> --- a/drivers/xen/netback/netback.c
> +++ b/drivers/xen/netback/netback.c
> @@ -128,7 +128,7 @@ static inline int netif_get_page_ext(struct page *pg, 
> unsigned int *_group, unsi
>   * packet processing on them (netfilter, routing, etc). 72 is enough

Missed this comment.

>   * to cover TCP+IP headers including options.
>   */
> -#define PKT_PROT_LEN 72
> +#define PKT_PROT_LEN    (ETH_HLEN + 4 + (15 * 4) + (15 * 4))

Clearer as:
#define ETH_HLEN_VLAN_HLEN + \
        MAX_IPOPTLEN + sizeof(struct iphdr) + \
        MAX_TCP_OPTION_SPACE + sizeof(struct tcphdr)
?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel