WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: Re: ç­¤ú Re: [Xen-devel][PATCH]qemu-xen: let xenfb_guest_copy() hand

Chun Yan Liu writes (" Re: Re: ç-¤úRe: [Xen-devel][ PATCH]qemu-xen: let xen 
fb_guest_copy() handle dept h=32 case"):
> In hw/xenfb.c, xenfb_guest_copy only handles xenfb->depth=8 and 24 cases, I 
> guess it assumes in xenfb->depth=16 or 32 cases, buffer is shared. But that's 
> not always the case: the code path that allows us to have a shared buffer 
> when xenfb->depth=16 or 32 is xenfb->do_resize set, but on a guest vnc 
> console, when enter CTRL+ALT+2 switch to qemu monitor console then CTRL+ALT+1 
> back to guest window, the xenfb->do_resize is not set, that is, buffer is not 
> shared, and xenfb_guest_copy does not handle xenfb->depth=32 case, the result 
> is: guest screen cannot be restored.
> 
> To fix above problem, this patch does two things:
> 1. Set xenfb->do_resize in xenfb_invalidate so that in console switch case, 
> buffer is shared when xenfb->depth=16 or 32. The screen cannot be restored 
> bug in above description can be solved.
> 2. To avoid that other special cases have the same problem, it's better to 
> let xenfb_guest_copy handle all cases, so add processing to xenfb->depth=16 
> and 32 in xenfb_guest_copy.

I have applied this patch, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Re: ç­¤ú Re: [Xen-devel][PATCH]qemu-xen: let xenfb_guest_copy() handle depth=32 case [and 1 more messages], Ian Jackson <=