WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Tue, 14 Dec 2010 10:18:13 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Tue, 14 Dec 2010 02:23:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C92CF105.CCEF%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C92CF06D.CCE3%keir@xxxxxxx> <C92CF105.CCEF%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
At 10:01 +0000 on 14 Dec (1292320899), Keir Fraser wrote:
> On 14/12/2010 09:59, "Keir Fraser" <keir@xxxxxxx> wrote:
> 
> >>> That's Tim's call. I would personally prefer for Xen to accept
> >>> truncated chunks, and extend them with sensible 'old save image' defaults,
> >>> such as all-zeroes.
> >>> That would be a generic solution to this case which will be reusable
> >>> in future, and avoid needlessly creating extra chunk types just for
> >>> backward compatibility reasons.
> >> 
> >> Ok. Let's wait for Tim to answer the call.
> > 
> > Well I propose the attached patch, and then you can use
> > hvm_load_entry_zeroextend() in vlapic.c. I would split this patch into two
> > pieces if I apply it (code movement first, then the zeroextend logic).
> > 
> > It needs an Ack from Tim however.

Looks good. 

Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel