WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] regression from c/s 22071:c5aed2e049bc (ept: Put locks aroun

To: "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx>
Subject: [Xen-devel] regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ?
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 14 Dec 2010 08:39:06 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 14 Dec 2010 00:40:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
George,

with ept_get_entry() calling ept_pod_check_and_populate(), which in
turn unconditionally calls p2m_lock(), we got a report of the BUG() in
p2m_lock() triggering (in a backport of the patch on top of 4.0.1 - the
logic seems unchanged in -unstable, and hence the issue ought to
similarly exist there). Wouldn't therefore ept_pod_check_and_populate(),
only ever called from ept_get_entry(), not need to do any locking on
its own at all?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel