Re: [Xen-devel] [PATCH 1 of 4] pyxl: Fix refcounting of Py_None

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-12-09 at 13:54 +0000, Gianni Tedesco wrote:
> @@ -354,6 +356,7 @@ static PyObject *pyxl_list_domains(XlObj
>              goto err_mem;
>          memcpy(&di->obj, cur, sizeof(di->obj));
>          PyList_SetItem(list, i, (PyObject *)di);
> +        Py_DECREF(di);
>      }

This part is erroneous because PyList_SetItem, unlike PyList_(Insert|
Append), steals a reference.

Let's NAK this entire series and I'll respin a fixed a version, possibly
with some other updates.

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel