WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4 of 4] Support new xl command cpupool-numa-split

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 4 of 4] Support new xl command cpupool-numa-split
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Wed, 08 Dec 2010 14:17:29 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 08 Dec 2010 05:18:41 -0800
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1291814267; x=1323350267; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4CFF8569.4010104@xxxxxxxxxxxxxx>|Date:=20 Wed,=2008=20Dec=202010=2014:17:29=20+0100|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>|MIME-Version: =201.0|To:=20Ian=20Campbell=20<Ian.Campbell@xxxxxxxxxxxxx >|CC:=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@list s.xensource.com>|Subject:=20Re:=20[Xen-devel]=20[PATCH=20 4=20of=204]=20Support=20new=20xl=20command=09cpupool-numa -split|References:=20<f31333fe3b3553c90419.1290755427@mer ano1.osd.mch.fsc.net>=09<1291806978.13966.4529.camel@zaka z.uk.xensource.com>=09<4CFF7812.4050506@xxxxxxxxxxxxxx> =20<1291813922.13966.4553.camel@xxxxxxxxxxxxxxxxxxxxxx> |In-Reply-To:=20<1291813922.13966.4553.camel@xxxxxxxxxxxx source.com>|Content-Transfer-Encoding:=207bit; bh=Z3kWiZa+n9xPFhQEkHDCvjcZ7prw+iRFeBBpLggSOHU=; b=g5i/lwcg0V9LVtSNTxymfGxOqJxU4Oi1PeRa8RGkNZ7MSJ9aZbzkHF9X 9ogMRqfyiBGSdEAILVhDrdPLx+nBYkkXqMNbPsnGvrv40byLIAum7wYRz 3Kg7iYt+8PApxypX+c4ADr4nA/L3LNDQZ0syvfL5ij1sKwUFsfv8+w9Ya f2W4pfutkWUiF+UwQ+ASd87mF3HKuFb5t4yNia9tYGCgeJjqwXDjVWy7g 98ZJF3N/l65zZxXPX+SZrw237GX4x;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=HzRm5+sLych9g+4R02vgmUxaccIamX8VjbtgKCmoHDEt5LGRAUj3eNVb oSSvbGF8cAbWo4lK5Q2QTmj0C8U/zRTmQCVyrT2BerAA8Ba6JudlwH1+H mRyd2AJuHncKMVazqt4wcO/XLYPAEGjs4D9HFBn75Na1LLfs3INE1ZdNB McSExWyFk1bwt/WlRB3gQ0i5IzJo2tHXaBlCimrXHjOkh3dp1dCOQfZ13 2IUZbCF4DqUC0lINl/zMvozhSuQym;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1291813922.13966.4553.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <f31333fe3b3553c90419.1290755427@xxxxxxxxxxxxxxxxxxxxxxx> <1291806978.13966.4529.camel@xxxxxxxxxxxxxxxxxxxxxx> <4CFF7812.4050506@xxxxxxxxxxxxxx> <1291813922.13966.4553.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101030 Iceowl/1.0b1 Icedove/3.0.10
On 12/08/10 14:12, Ian Campbell wrote:
On Wed, 2010-12-08 at 12:20 +0000, Juergen Gross wrote:
On 12/08/10 12:16, Ian Campbell wrote:
Can this loop be merged with the preceding loop, with the body being the
else case of the if?

No. I have to add new cpus first to avoid a cpupool without cpus in between.

ok.

I was thinking that because this function only gets here if there is a
single pool that all CPUs must be in that pool -- but that's not
actually true is it? Even if that were the common case there's nothing
to enforce that.

Perhaps I should add a comment to avoid a problem later...


Do we want to rename Pool-0 at some point too or do we rely on that name
elsewhere?

Good question. There is a hard coded "Pool-0" reference in libxl, but this
could easily be changed.
I'm not sure about implications in xm/xend. I'll check this.

I don't think there is a particularly strong requirement to allow xend
and xl to coexist. I'd recommend just leaving xend doing what it does
today and fix xl/libxl only.

Okay, I'll modify xl to rename Pool-0 to Pool-node[n].


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel