[Xen-devel] Re: [PATCH] xen: gntdev: move use of GNTMAP_contains_pte next to the map_op

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2010-12-08 at 11:53 +0000, Ian Campbell wrote:
> This flag controls the meaning of gnttab_map_grant_ref.host_addr and
> specifies that the field contains a refernce to the pte entry to be
> used to perform the mapping. Therefore move the use of this flag to
> the point at which we actually use a reference to the pte instead of
> something else, splitting up the usage of the flag in this way is
> confusing and potentially error prone.
> 
> The other flags are all properties of the mapping itself as opposed to
> properties of the hypercall arguments and therefore it make sense to
> continue to pass them round in map->flags.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> Cc: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
> Cc: Derek G. Murray <Derek.Murray@xxxxxxxxxxxx>
> Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> ---
>  drivers/xen/gntdev.c    |    5 +++--
>  drivers/xen/hypercall.c |   18 ++++++++++++++----

Damn, a bunch of other hacking got added here by mistake, I'll resend!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel