Re: [Xen-devel] [PATCH 3/4] amd iommu: Large io page support - enablement

[Keir Fraser <keir@xxxxxxx>]

Well, let's see. The change to p2m_set_entry() now allows (superpage) calls
to the iommu mapping functions even if !need_iommu(). That seems a semantic
change. Also I don't want the superpage command-line parameter, but I see
why you added it, as you couldn't be bothered to fix up the Intel side to
work properly, so you left in the onld p2m_set_entry() code for that case.
That's unacceptable. Get rid of the command-line parameter, get rid of the
new [un]map_pages iommu hooks and extend the existing map/unmap hooks
instead, and naturally do that for the Intel side as well as the AMD side
(of course, on the Intel side you can just do a dumb implementation of
map_pages which just loops over the existing single-page-at-a-time code --
you need to keep the Intel side working, but you don't have to do the work
to make it faster than it is already).

I'm going to stop reading this patch series now and wait for a better one.

 -- Keir

On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> Enable super iommu support on amd systems.
> Thanks,
> We
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> Legal Information:
> Advanced Micro Devices GmbH
> Sitz: Dornach, Gemeinde Aschheim,
> Landkreis München Registergericht München,
> HRB Nr. 43632
> Geschäftsführer:
> Alberto Bozzo, Andrew Bowd
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel