Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - I

To:	Wei Wang2 <wei.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
From:	Keir Fraser <keir@xxxxxxx>
Date:	Fri, 03 Dec 2010 08:17:32 -0800
Cc:
Delivery-date:	Fri, 03 Dec 2010 08:20:24 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=jnJmHr7wgGCSPm/+Pj5XcES92MgmAFEP4NhpgcSyRAk=; b=FGC7oqf90NgXLd8tchUiWx+zsNp8KPIT8B1G4CWNcVyXXXAJdpYlA/YdnBv1nk3Mhl ooK57u4e39q08a9CdFlUshlD4s1+ulzXRrqlfpLrguFQsIzn+yYjYoXv273ODynebtrA 5KhpaK22HHh+YiXdYqWJ9fvtpSP7PAUoPSd6c=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=MTmgrR1bLrXA+sSt3hlQnCjpm/iKDFtlS5RkZjY6TQBDKikp0qob6RfoyzAlTXcUED QacwSKd5vMboE/h1kA5ijMuxGepUynW56AkNuC+qbGJKzRbRm9O9OUsNncKzGT1jJlO3 e3MPtJlQLyJ3284TAZwzN7aHZMs7UE+9hJEtU=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<201012031703.30686.wei.wang2@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcuTBZaKiGvGiy+z5E+xTMh6k8PkuA==
Thread-topic:	[Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
User-agent:	Microsoft-Entourage/12.23.0.091001

Why add new map/unmap calls. Better just to extend the existing calls to be
able to act on a range, eh? That way you won't end up stubbing out and
breaking Intel support in patch 3, either...

 -- Keir

On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> This patch extends generic iommu interfaces to support different page size.
> 
> Thanks,
> Wei
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> Legal Information:
> Advanced Micro Devices GmbH
> Sitz: Dornach, Gemeinde Aschheim,
> Landkreis München Registergericht München,
> HRB Nr. 43632
> Geschäftsführer:
> Alberto Bozzo, Andrew Bowd
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface