WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: dom0 pvops crash apparently due to guest migration

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] Re: dom0 pvops crash apparently due to guest migration
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 30 Nov 2010 12:37:18 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Tue, 30 Nov 2010 12:38:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C91A9BCD.B7E1%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C91A9BCD.B7E1%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6
On 11/30/2010 04:17 AM, Keir Fraser wrote:
> On 29/11/2010 18:53, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:
>
>> Hm, I'm still not really sure why alloc_vm_area() does a
>> vmalloc_sync_all in the first place...  But that BUG shouldn't happen
>> regardless.
> I think vmalloc_sync_all() is required only if alloc_vm_area()'d regions are
> used as hypercall buffers. I'm not sure if they ever are, these days.

Doesn't look like it.  And it would need the buffer to be filled out by
one task and then the hypercall issued by another one, which seems unlikely.

And even if we did issue hypercalls from a vmalloc area, it shouldn't be
alloc_vm_area()'s job to make sure that works, since its a generic core
function now.

    J


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>